test(trace) remove test skip and stop mocking console error #80158
+354
−298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80158 +/- ##
==========================================
+ Coverage 78.08% 78.37% +0.28%
==========================================
Files 7179 7177 -2
Lines 317124 317037 -87
Branches 43724 43710 -14
==========================================
+ Hits 247637 248481 +844
+ Misses 63145 62224 -921
+ Partials 6342 6332 -10 |
Bundle ReportChanges will increase total bundle size by 207 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed a large set of tests wrt trace view. The last set of issues related to search seem to be caused by a race condition between user input and a delayed layout effect. The flaky tests have been disabled for now while I figure out the root cause or an alternative approach to fire the side effect.
I'm going to re-run the frontend suite 10 times to ensure this doesnt flake again.